On Mon, Feb 22, 2010 at 3:25 PM, Carlos O'Donell <carlos@xxxxxxxxxxxxxxxx> wrote: > Kyle, > > I spent the weekend bisecting to determine which patch broke booting > from scsi on my rp2470. ... > The attached patch allows me to boot again by setting the PCI CLS to > 64 early-on in pcibios_init(). What is the boot failure message? > I don't know *why* it works, what a shame, can anyone see something I've missed? pci_cache_line_size is uninitialized and I expect is zero. If zero, pci_set_cacheline_size() immediately returns an error and causes the sym53c8xx_2 driver to assert there is no SCSI host controller present (returns -ENODEV). Ergo no booting. fs_initcall_sync(pci_apply_final_quirks) should be called before the device_initcall() stuff. I expect pci_cache_line_size should be non-zero before sym2 driver is invoked. There was a bug in pci_apply_final_quirks() could cause pci_set_cacheline_size() to not set pci_cache_line_size, but the fix is in the current linus tree: http://patchwork.kernel.org/patch/69755/ Is it possible your tree is missing that fix for some reason? In any case, your patch looks good to me. Please add: Reviewed-by: Grant Grundler <grundler@xxxxxxxxxx> thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
