> The root cause is a duplicate section name (.text); is this legal? > > However, there's a problem with commit > 6d76013381ed28979cd122eb4b249a88b5e384fa in that if you fail to allocate > a mod->sect_attrs (in this case it's null because of the duplication), > it still gets used without checking in add_notes_attrs() > > This should fix it > > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxx> Thanks! I tested it, and it does at least fix the kernel crash. Tested-by: Helge Deller <deller@xxxxxx> > diff --git a/kernel/module.c b/kernel/module.c > index fd14114..a703c49 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -2353,7 +2353,8 @@ static noinline struct module *load_module(void > __user *umod, > if (err < 0) > goto unlink; > add_sect_attrs(mod, hdr->e_shnum, secstrings, sechdrs); > - add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs); > + if (mod->sect_attrs) > + add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs); > > /* Get rid of temporary copy */ > vfree(hdr); > -- Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3 - sicherer, schneller und einfacher! http://portal.gmx.net/de/go/atbrowser -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
