On Tue, Jun 16, 2009 at 10:51:48PM +0200, Helge Deller wrote: > On 06/15/2009 01:20 AM, John David Anglin wrote: >> I am convinced that interrupts need to be disabled on SMP kernels to >> prevent deadlock. On UP kernels, I am not convinced that anything bad >> happens if we do a tlb purge while handling an interrupt since we don't >> have to worry about preventing bus conflicts. The UP code can't >> deadlock. I'm thinking that we can stay with disabling preemption. > > Dave is right and it took me long to understand his point... > I continued testing and we can simply just disable preemption for UP > kernels and use an irq-safe spinlock for SMP kernels. > > Below is the latest and greatest patch which fixes this bug. > Run-tested onUP kernels and compile-tested on SMP kernels. > Ugh, I'd really prefer it if we just took the irq disable and enable hit on UP by making the codepaths the same... Is that ok with you or? Kyle > Kyle, it would be nice if you could apply it as soon as possible. > The bug is existing since a long time, so it might make sense to backport > it to older kernels as well... > -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
