Re: [PATCH, RFC] fix parisc runtime hangs wrt pa_tlb_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I mentioned in my original mail that this is not the final version:
> > The patch below is just a hack. It will need a cleanup and is just to open
> > discussions here on the list.
> 
> But instead of cleaning it up right now, I would be very much interested if
> this patch fixes the kernel stalls you see as well?

I can't say that I see kernel stalls on any of my machines.  However,
I do see memory corruption that I have reported a number of times.  I also
see a user/group id bug that also could be a memory corruption bug
(pam cache).  I think there's a good possibility that your patch may
help.

I have a version installed on top of 2.6.30-rc6 on my rp3340.  I haven't
done a lot of testing with it, but it boots and I have done one kernel
build with it.  Didn't include lock in macro as you show below.

I was looking a couple of the warnings:
arch/parisc/kernel/time.c:184: warning: initialization from incompatible pointer type
arch/parisc/kernel/irq.c:123: warning: passing argument 1 of 'cpumask_setall' from incompatible pointer type
arch/parisc/kernel/irq.c:141: warning: passing argument 1 of 'cpumask_copy' from incompatible pointer type
arch/parisc/kernel/irq.c:300: warning: passing argument 1 of 'cpumask_copy' from incompatible pointer type
arch/parisc/kernel/irq.c:357: warning: passing argument 2 of 'cpumask_copy' from incompatible pointer type

The first is due to the missing argument in read_cr16.  I believe a fix
was posted to the list.

The latter warnings seem due to a change in the type of the affinity field
of the irq_desc struct.

> If it does, then I agree that we should add a "flags" argument to purge_tlb_xxx() functions, e.g.
> - purge_tlb_start(lock, flags) 
> - purge_tlb_end(lock, flags)

Dave
-- 
J. David Anglin                                  dave.anglin@xxxxxxxxxxxxxx
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux