On Wed, 25 Feb 2009, David Woodhouse wrote: > On Mon, 2009-02-23 at 13:34 +0100, Geert Uytterhoeven wrote: > > > my opinion on this kind of stuff is that I want to avoid the layering > > > of implementations under the rtc subsystem. I'd rather prefer that each > > > rtc device had its own driver. > > > > > > I've made error in the past, by accepting such kind of drivers, and > > > would like to avoid that it happens again. > > > > So you want us to kill the ppc_md.[gs]et_rtc_time() [ppc], mach_hwclk() [m68k], > > mach_gettod() [m68knommu] (and probably a few other) abstractions, and move all > > RTC code out of arch/ into seperate drivers under drivers/rtc/ instead? > > That's the ideal... although did we get NTP sync working again yet? > > The rtc-ppc driver was intended as a short-term workaround so that we > can enable the generic RTC class (which was required for PA Semi > Electra, iirc), and still have stuff work on other platforms. Sure. The only differences between your rtc-ppc driver and rtc-parisc were: - rtc-ppc uses the PPC RTC abstraction (ppc_md.[gs]et_rtc_time()), while rtc-parisc uses the genrtc abstraction layer ([gs]et_rtc_time()), which is shared by several architectures, - rtc-ppc has the platform device built-in in the driver, while rtc-parisc relies on the creation of the platform device in platform code. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html