On Mon, Jan 26, 2009 at 05:55, Grant Grundler <grundler@xxxxxxxxxxxxxxxx> wrote:
> On Sun, Jan 25, 2009 at 11:53:16PM +0100, Kay Sievers wrote:
>> From: Kay Sievers <kay.sievers@xxxxxxxx>
>> Subject: parisc: struct device - replace bus_id with dev_name(), dev_set_name()
>
> In general, no objection. Just one nit below.
>
> Otherwise, please add:
> Reviewed-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
>> printk(KERN_ERR "Dino: cannot attach bus %s\n",
>> - bus->bridge->bus_id);
>> + dev_name(bus->bridge));
>
> I think the "cannot attach bus" string needs to be changed to
> "cannot attach dev" or whatever dev_name() is supposed to represent.
The code probably uses a "struct device" to represent a "bus", which
sounds fine because the "devices" are more "objects" than "devices"
sometimes.
> While the code in include/linux/device.h is using "bus_id",
> the comments say:
>
> static inline const char *dev_name(const struct device *dev)
> {
> /* will be changed into kobject_name(&dev->kobj) in the near future */
> return dev->bus_id;
> }
It's the "name" of a "device", the comment has already gone away with
the final patch in the bus_id series.
Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
