Re: HPMC bus timeout on C3600

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 02, 2009 at 08:24:50PM -0500, John David Anglin wrote:
> > Something like this? Sorry, I've almost completely forgotten gas syntax
> > and all that jazz...
> 
> Yes.  The gas syntax looks correct except you probably should add a
> .align 4.  I would use local labels (that's what's what is done for
> debug and exception info).  Just place the local labels adjacent to
> os_hpmc and os_hpmc_end.  This ensures the diff is absolute.
> 

Ahh, excellent. Thanks.

> > -ENTRY(os_hpmc_end)	/* this label used to compute os_hpmc checksum */
> > +ENTRY(os_hpmc_end)
> 
> Probably, you don't need to export os_hpmc_end.
> 

Indeed.

> > -	length = os_hpmc_end - os_hpmc;
> > +	length = os_hpmc_size * sizeof(u32);
> 
> I believe the size will be correct without multiplying by sizeof(u32).
> 

Ah, indeed. Good point.

cheers, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux