On Fri, Jan 02, 2009 at 04:14:12PM -0500, John David Anglin wrote:
> > On Fri, Jan 02, 2009 at 09:46:44PM +0100, Guy Martin wrote:
> > > OS HPMC handler length needs to be in bytes, not in words.
> > > Signed-off-by: Guy Martin <gmsoft@xxxxxxxxxxxx>
> > >
> > > - length = os_hpmc_end - os_hpmc;
> > > + length = (os_hpmc_end - os_hpmc) * sizeof(u32);
> > > ivap[7] = length;
> >
> > Ick. I wonder if I screwed that up when I fixed the function descriptor
> > breakage...
>
> The fix doesn't seem right. Probably, os_hpmc and os_hpmc_end are
> pointing to function descriptors.
>
I think we've been over this before ;-)
commit c3d4ed4e3e5aa8d9e6b4b795f004a7028ce780e9
Author: Kyle McMartin <kyle@xxxxxxxxxxxxxxxx>
Date: Mon Jun 4 02:26:52 2007 -0400
[PARISC] Fix kernel panic in check_ivt
check_ivt had some seriously broken code wrt function pointers on
parisc64. Instead of referencing the hpmc code via a function
pointer,
export symbols and reference it as a const array.
Thanks to jda for pointing out the broken 64-bit func ptr handling.
Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxxxxxxxx>
cheers, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
