On Sun, 2008-12-07 at 23:58 -0500, Kyle McMartin wrote: > On Sun, Dec 07, 2008 at 08:55:59PM -0800, Harvey Harrison wrote: > > On Sun, 2008-12-07 at 23:43 -0500, Kyle McMartin wrote: > > > These were using __fswabX which is marooned in <linux/byteorder/swab.h> > > > instead we'll just use the __arch_swabX defines from <asm/byteorder.h> > > > > > > > Sorry I missed this usage :-/ > > > > Any reason not to just use __swab16 __swab32 __swab64? I'd like to keep > > the __arch helpers confined to swab.h only. > > > > Not particularly, I believe the idea of using fswabX was to Make Damned > Sure(tm) that gcc wouldn't eliminate the expression by being too smart > for its own good. It's probably fine now, though I have half a mind to > just fold it in. By fold it in, I take it to mean, write them as static inlines rather than macros, if so, I definitely approve. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html