On Wed, Dec 03, 2008 at 12:16:04AM +0100, Roel Kluin wrote:
> set_rtc_time returns negative on error, ret should be signed to catch those
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
Reviewed-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
> ---
> diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c
> index 346d633..c6bfa6f 100644
> --- a/drivers/rtc/rtc-parisc.c
> +++ b/drivers/rtc/rtc-parisc.c
> @@ -34,7 +34,8 @@ static int parisc_get_time(struct device *dev, struct rtc_time *tm)
> static int parisc_set_time(struct device *dev, struct rtc_time *tm)
> {
> struct parisc_rtc *p = dev_get_drvdata(dev);
> - unsigned long flags, ret;
> + unsigned long flags;
> + int ret;
>
> spin_lock_irqsave(&p->lock, flags);
> ret = set_rtc_time(tm);
Use of unsigned is wrong given the later code in parisc_set_time() does:
if (ret < 0)
return -EOPNOTSUPP;
I expected a compiler "out of range"-like warning.
Someone know why no warning was emitted?
Or was one emitted and we've just ignored it?
thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
