On Mon, 17 Nov 2008, Helge Deller wrote: > > Fix an unitialized return value when compiling on parisc (with CONFIG_UNEVICTABLE_LRU=y): > mm/mlock.c: In function `__mlock_vma_pages_range': > mm/mlock.c:165: warning: `ret' might be used uninitialized in this function Looks valid. Of course, nobody should ever call this with a range that could possibly be empty, so an equally valid approach would be to change the "while" loop to a "do while()", and that would generate better code. But I guess the simple unnecessary initialization is more defensive programming, in that if some other buggy caller does set things up with an empty range, it gets the right result. Btw, exactly _because_ gcc warnings about uninitialized functions are sometimes bogus (ie due to gcc simply not being able to follow things like conditional initializations where the values are only used if they were initialized), I would ask that people comment on these kinds of issues when they send in patches. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
