On Tue, Aug 26, 2008 at 10:10 AM, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2008-08-26 at 08:42 -0400, Carlos O'Donell wrote: >> On Tue, Aug 26, 2008 at 12:26 AM, Grant Grundler >> <grundler@xxxxxxxxxxxxxxxx> wrote: >> > Thanks for tracking and resubmitting this...Carlos already ACK'd and I think >> > it would be good if kyle added it to his patch queue. >> > >> > But I liked two other things proposed in this thread. >> > 1) jejb's preference to document the alignement requirement >> > 2) jda's proposal for ENTRY_ALIGN() (which accomplishes (1)) >> > >> > So I've hacked your patch to include those two things. >> > >> > I've only build-tested this for 64-bit builds. >> > >> > thanks, >> > grant >> > >> > Signed-off-by: Helge Deller <deller@xxxxxx> >> > Signed-off-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx> > > Can we get this right, please ... we'll get into awful penguin trouble > if he catches us misusing the DCO: > >> Signed-off-by: Carlos O'Donell <carlos@xxxxxxxxxxxxxxxx> > > That's not signed off by you. You only get to add a signed-off-by if > the patch physically passes through your hands. That means that Grant's > above is correct because he modified the patch and resent it, but yours > isn't because you did nothing with it (and you didn't pass it on). > > You can add Acked-by: if you like (that usually means I'm the person in > charge of the relevant code and I approved sending it through someone > else's tree) or Reviewed-by: (I actually looked through the patch and it > seems to be fine to me). Quite right. Sorry for the cut-n-paste. Since I wrote the code, I consider myself the maintainer. Acked-by: Carlos O'Donell <carlos@xxxxxxxxxxxxxxxx> Cheers, Carlos. -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
