Re: [PATCH] fix comment in Light-weight-syscall code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 11, 2008 at 2:33 PM, Kyle McMartin <kyle@xxxxxxxxxxx> wrote:
> On Fri, Jul 11, 2008 at 01:02:10PM -0400, Carlos O'Donell wrote:
>> On Thu, Jul 10, 2008 at 4:04 PM, Helge Deller <deller@xxxxxx> wrote:
>> > The comment for the lws-atomic system call userspace helper
>> > function mentions r22 and r23 as input registers, but I couldn't
>> > find any usage of those registers in the code.
>> > This patch fixes this and corrects another small typo as well.
>>
>> That's the LWS syscall ABI. It has 5 argument registers, 1 return
>> register, 1 error code register, and 1 lws number register.
>>
>
> Yeah, but I think what Helge is asking is, if there's no plans to ever
> add more, or more arguments, can he change it to be 3 args?

No, I'm not OK with it, I think we should keep the extra two argument
registers for future use.

I've been talking to Helge about this. Once we lose those registers
they are gone from the ABI forever, and if we need some fixup, or an
additional arg in the future, it will be hard to handle.

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux