Hi,
On Mon, Mar 17, 2008 at 11:36:25AM +0200, S.?a??lar Onur wrote:
Sorry, I seem to be losing at charsets with your name. :(
> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values.
>
> So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly
>
I prefer the idea of using printk_ratelimit. I've committed a patch that
does this to git and credited you with pointing it out.
cheers, Kyle
> Cc: Kyle McMartin <kyle@xxxxxxxxxxx>
> Cc: linux-parisc@xxxxxxxxxxxxxxx
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: S.Ça??lar Onur <caglar@xxxxxxxxxxxxx>
> ---
> arch/parisc/kernel/unaligned.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/unaligned.c b/arch/parisc/kernel/unaligned.c
> index aebf3c1..19b8a79 100644
> --- a/arch/parisc/kernel/unaligned.c
> +++ b/arch/parisc/kernel/unaligned.c
> @@ -460,7 +460,7 @@ void handle_unaligned(struct pt_regs *regs)
> goto force_sigbus;
> }
>
> - if (unaligned_count > 5 && jiffies - last_time > 5*HZ) {
> + if (unaligned_count > 5 && time_after(jiffies, last_time + 5 * HZ)) {
> unaligned_count = 0;
> last_time = jiffies;
> }
> --
> 1.5.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
