* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [131114 01:46]: > Hi Tony, > > On 11/14/2013 04:35 AM, Tony Lindgren wrote: > > Commit c111feabe2e2 (gpio: twl4030: Cache the direction and output > > states in private data) improved things in general, but caused a > > regression for setting the GPIO output direction. > > > > The change reorganized twl_direction_out() and twl_set() and swapped > > the function names around in the process. While doing that, a bug got > > introduced that's not obvious while reading the patch as it appears > > as no change to the code. > > > > The bug is we now call function twl4030_set_gpio_dataout() twice in > > both twl_direction_out() and twl_set(). Instead, we should first > > call twl_direction_out() in twl_direction_out() followed by > > twl4030_set_gpio_dataout() in twl_set(). > > > > This regression probably has gone unnoticed for a long time as the > > bootloader may have set the GPIO direction properly in many cases. > > This fixes at least the LCD panel not turning on omap3 LDP for > > example. > > Thanks for catching this. I have a recollection that I have tested the GPIO > and it appeared to be working fine.. Yes it probably worked fine if the bootloader set the direction :) This is cc stable kind of patch for sure. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
