Re: [PATCH] twl4030_charger: add devicetree support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Oct 24, 2013, at 5:41 AM, NeilBrown wrote:

> On Thu, 24 Oct 2013 11:06:52 +0100 Grant Likely <grant.likely@xxxxxxxxxx>
> wrote:
> 
>> On Thu, 24 Oct 2013 04:44:03 -0500, Kumar Gala <galak@xxxxxxxxxxxxxx> wrote:
>>> 
>>> On Oct 24, 2013, at 12:50 AM, NeilBrown wrote:
>>> 
>>>> 
>>>> [my first device-tree related patch.  Please let me know what I got wrong so
>>>> I wont repeat the mistake in all the others I have queued]
>>>> 
>>>> This allows the charger to be enabled with devicetree, and
>>>> allows the parameters for charging the backup battery to be set.
>>>> 
>>>> Signed-off-by: NeilBrown <neilb@xxxxxxx>
>>>> 
>>>> diff --git a/Documentation/devicetree/bindings/power/twl-charger.txt b/Documentation/devicetree/bindings/power/twl-charger.txt
>>>> new file mode 100644
>>>> index 0000000..8afaa9a
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/power/twl-charger.txt
>>>> @@ -0,0 +1,20 @@
>>>> +TWL BCI (Battery Charger Interface)
>>>> +
>>>> +Required properties:
>>>> +- compatible:
>>>> +  - "ti,twl4030-bci"
>>>> +- interrupts: two interrupt lines from the TWL SIH (secondary
>>>> +  interrupt handler) - interrupts 9 and 2.
>>>> +
>>>> +Optional properties:
>>>> +- bb-uvolt: microvolts for charging the backup battery.
>>>> +- bb-uamp: microamps for charging the backup battery.
>>> 
>>> prop should have vendor prefix.
>>> 
>>> ti,bb-uvolt, ti,bb-uamp
>> 
>> Agreed. Otherwise:
> 
> OK, I'll do that - thanks.
> 
> NeilBrown

Ditto on the Ack once these changes are made:

Acked-by: Kumar Gala <galak@xxxxxxxxxxxxxx>

- k

> 
>> 
>> Acked-by: Grant Likely <grant.likely@xxxxxxxxxx>
>> 
>>> 
>>> - k
>>> 
>>>> +
>>>> +Examples:
>>>> +
>>>> +bci {
>>>> +   compatible = "ti,twl4030-bci";
>>>> +   interrupts = <9>, <2>;
>>>> +   bb-uvolt = <3200000>;
>>>> +   bb-uamp = <150>;
>>>> +};
>>> 
>>> -- 
>>> Employee of Qualcomm Innovation Center, Inc.
>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>>> 
> 

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux