> From: Brian Norris [mailto:computersforpeace@xxxxxxxxx] > > On Tue, Oct 15, 2013 at 11:19:51AM +0530, Pekon Gupta wrote: > > This patch updates following in omap_nand_probe() and > omap_nand_remove() > > - replaces "info->nand" with "nand_chip" (struct nand_chip *nand_chip) > > - replaces "info->mtd" with "mtd" (struct mtd_info *mtd) > > - white-space and formatting cleanup > > > > Signed-off-by: Pekon Gupta <pekon@xxxxxx> > > This patch looks good. Thanks for being consistent. > > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > > index 8d521aa..5596368 100644 > > --- a/drivers/mtd/nand/omap2.c > > +++ b/drivers/mtd/nand/omap2.c > > ... > > > @@ -1846,17 +1848,16 @@ static int omap_nand_probe(struct > > - > > - info->nand.options = pdata->devsize; > > - info->nand.options |= NAND_SKIP_BBTSCAN; > > + mtd = &info->mtd; > > + mtd->priv = &info->nand; > > + mtd->name = dev_name(&pdev->dev); > > + mtd->owner = THIS_MODULE; > > + nand_chip = &info->nand; > > + nand_chip->options = pdata->devsize; > > Trivial side comment: the 'devsize' field is not named very > informatively. It is apparently just a way to specify nand_chip.options, > and it is only actually used for setting a buswidth. (It is also badly > named nand_type in other places.) Not sure if it's worth improving, or > even dropping at some later point in time. > For now I'm keeping this name consistent for now, as this would require touching GPMC driver also, where 'devsize' is used to configure GPMC controller registers. I'll keep this feedback as pending for independent patch where I probe driver with "NAND_BUSWIDTH_AUTO". with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
