On Wed, Oct 16, 2013 at 9:24 AM, Manish Badarkhe <badarkhe.manish@xxxxxxxxx> wrote: > >> >> IMHO, fail of creation of debugfs is not reason enough to fail the >> probe - further, this code needs a major revamp to work with device tree. > > Yes, fail of debugfs creation should not be enough reason to fail probe. But as > per current implementation of code, on debugfs failure smart reflex node is > getting deleted and probe get failed. This patch not made any changes in > logic of code but only makes proper use of "IS_ERR_OR_NULL". Thanks for the clarification, it was not obvious from the commit message. Further, I would rather prefer to see a proper cleanup that handles error completely, since IS_ERR_OR_NULL is not really recommended anymore. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
