Re: [PATCH 1/1] gpio/omap: use gpiolib API to mark a GPIO used as an IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/2013 10:06 AM, Linus Walleij wrote:
> On Wed, Oct 16, 2013 at 2:47 AM, Javier Martinez Canillas
> <javier.martinez@xxxxxxxxxxxxxxx> wrote:
> 
>> The OMAP GPIO driver keeps track about GPIO pins that are
>> used as IRQ lines for two reasons:
>>
>> 1) To prevent GPIO banks to be disabled while one of their
>>    GPIO pins are only used as an interrupt line.
>>
>> 2) To not allow another caller to set the GPIO pin as output.
>>
>> Now gpiolib has an API to mark GPIO pins as used as IRQ lines
>> so the GPIO core only allows to set as output GPIO pins not
>> tied to an IRQ. So there is no need to have custom code for 2).
>>
>> The IRQ usage still has to be maintained locally for 1) though.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> 
> Patch applied. I had to merge in v3.12-rc4 to get the dependency
> fixes, so I guess you did something similar when developing
> this...
>

Thanks and yes since this is not a critical bug it was meant to be for v3.13 on
top of fac7fa162 ("gpio/omap: auto-setup a GPIO when used as an IRQ") and after
you have merged your flag-irqs branch.

Sorry for not explicitly mentioning this dependency.

> Yours,
> Linus Walleij
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux