On Mon, Aug 26, 2013 at 08:15:17PM +0200, Arnd Bergmann wrote: > On Monday 26 August 2013 19:40:57 Vinod Koul wrote: > > And the selection should be done for the cases where you dont have programmable > > mux in dmac. For programmable ones passing slave_id in dma_slave_config should > > be fine. > > I think passing a slave_id from the slave driver is never correct with DT, > since the ID is a property of the system rather than the slave device, so > the driver has no access to it. Drivers have to always take the settings > from DT and ignore what dma_slave_config() sets later. Shouldnt slave id be property of the client driver. That way we can pass it to the driver using dma_slave_config(). That should make it right.. ~Vinod -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
