On Tuesday 27 August 2013 12:17 PM, Laurent Pinchart wrote:
On Tuesday 27 August 2013 05:20:45 Linus Walleij wrote:
On Mon, Aug 26, 2013 at 8:21 AM, Archit Taneja <archit@xxxxxx> wrote:
Add code to parse the GPIO expander Device Tree node and extract platform
data out of it, and populate the struct 'pcf857x_platform_data'
maintained by the driver. This enables devices to reference the gpio
expander from Device Tree.
Add DT binding info in Documentation.
Signed-off-by: Archit Taneja <archit@xxxxxx>
---
- v2 posted after quite a while, sorry for the delay!
Changes in v2:
- second gpeio-cell description corrected in Documentation
- interrupt controller description removed for now, will be added in a
follow up patch
- n_latch description updated
And it seems that the patch conflicts with
https://lkml.org/lkml/2013/8/26/248
:-/
:/
If we end up merging this one, I'd like to at least rename the DT n-latch
property to pin-initial-states as in my patch and update the documentation, as
I find it more explicit.
I think your patch is cleaner and more descriptive. The only thing which
I am not clear about in your patch is the extra work done in getting
ngpio, that should be available in i2c_device_id pointer argument in
probe(id points to the array pcf857x_id already available in the driver
with the number of gpios for each chip variant).
Archit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
