On Sun, Aug 11, 2013 at 10:27 AM, Mark Jackson <mpfj-list@xxxxxxxxxxxxx> wrote: > On 08/07/13 19:57, Mark Jackson wrote: >> NanoBone Specification: >> ----------------------- >> CPU: >> TI AM335x @ 720MHz >> >> Memory: >> 256MB DDR3 >> 128MB NOR flash >> 128KB FRAM >> >> Ethernet: >> 2 x 10/100 connected to SMSC LAN8710 PHY >> >> USB: >> 1 x USB2.0 Type A >> >> I2C: >> 2Kbit EEPROM (Microchip 24AA02) >> RTC (Maxim DS1338) >> GPIO Expander (Microchip MCP23017) >> >> Expansion connector: >> 6 x UART >> 1 x MMC/SD >> 1 x USB2.0 >> >> Signed-off-by: Mark Jackson <mpfj@xxxxxxxxxxxxx> >> --- >> MAINTAINERS | 6 + >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/am335x-nano.dts | 388 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 395 insertions(+) >> create mode 100644 arch/arm/boot/dts/am335x-nano.dts > > Any comments on this new board file ? Hi Mark, Overall it looks very good to me, I just have one small comment. Please don't redefine device nodes that are already defined in the included am33xx.dtsi file (pinmux, ocp, gpmc, etc). You should just use what is defined there instead of defining it again in your board DT file. Also these are IP modules that are internal details of the SoC so is better to keep them outside of board DT files definition. Please take a look to my am33xx cleanups series [1] to see how it should be defined. Once you have made that changes feel free to add my: Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> Benoit seems to be on holidays so please be patient with him taking your patch. [1]: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg93738.html Thanks a lot and best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
