On 07/30/2013 10:42 PM, Nishanth Menon wrote:
On 07/23/2013 02:20 AM, Tero Kristo wrote:
diff --git a/arch/arm/mach-omap2/cclock44xx_data.c
b/arch/arm/mach-omap2/cclock44xx_data.c
deleted file mode 100644
index 88e37a4..0000000
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ /dev/null
[...]
-
-int __init omap4xxx_clk_init(void)
-{
arch/arm/mach-omap2/clock44xx.h:int omap4xxx_clk_init(void);
arch/arm/mach-omap2/io.c: omap_clk_init = omap4xxx_clk_init;
code in drivers/clk/omap/clk-44xx.c
Seems goofy to me a little.
entire purpose of having a clk-44xx.c is:
a) doing a clk alias for device nodes
I am not quite sure we have mechanisms for doing this (yet).
b) set_parent, rate
I think this is maybe an idea for future dev and Mike to consider if he
wants generic clock nodes to have such properties.
both of these seem to be an old style carry forward and should instead
be fixes with generic properties IMHO voiding the need for SoC specific
inits.
instead all we should be doing is call of_clk_init(NULL); at appropriate
init sequence.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
