On Mon, Jul 29, 2013 at 03:13:07PM +0530, Sourav Poddar wrote: > On Monday 29 July 2013 03:02 PM, Felipe Balbi wrote: > >On Mon, Jul 29, 2013 at 12:52:30PM +0530, Sourav Poddar wrote: > >>Since, qspi controller uses quad read. > >> > >>Configuring the command register, if the transfer of data needs > >>dual or quad lines. > >> > >>This patch has been done on top of the following patch[1], which is just the > >>basic idea of adding dual/quad support in spi framework. > >>$subject patch will undergo changes with the ongoing discussion in the > >>community. > >> > >>This patch is posted to demonstrate how patch 1 of the series will support > >>quad read. > >> > >>[1]: http://comments.gmane.org/gmane.linux.kernel.spi.devel/14047 > >> > >>Signed-off-by: Sourav Poddar<sourav.poddar@xxxxxx> > >>--- > >> drivers/spi/spi-ti-qspi.c | 16 ++++++++++++++-- > >> 1 files changed, 14 insertions(+), 2 deletions(-) > >> > >>diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c > >>index 51fe95f..8a32b1c 100644 > >>--- a/drivers/spi/spi-ti-qspi.c > >>+++ b/drivers/spi/spi-ti-qspi.c > >>@@ -86,6 +86,7 @@ struct ti_qspi { > >> #define QSPI_3_PIN (1<< 18) > >> #define QSPI_RD_SNGL (1<< 16) > >> #define QSPI_WR_SNGL (2<< 16) > >>+#define QSPI_RD_DUAL (3<< 16) > >> #define QSPI_RD_QUAD (7<< 16) > >so RD_QUAD is defined in previous patch but not RD_DUAL ? What gives ? > > > I think I will define RD_DUAL in the previous patch... > >IMHO, just merge this patch with previous and make the entire driver > >depend on the other patch. > > > but I was thinking of keeping rest of the $subject patch seperate, since the > idea of implementing dual/quad read in spi framework is still under > discussion. > and this patch will change. > > So, it would be good if we can get the basic previous patch in, and > then when the > other discussion is sorted out, we can get this in? alright, in that case it makes sense. -- balbi
Attachment:
signature.asc
Description: Digital signature
