On Fri, Jun 7, 2013 at 10:50 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> +static irqreturn_t pcs_omap_handle_irq(int irq, void *data)
> +{
> + struct pcs_omap *pcso = data;
> + struct list_head *pos;
> + unsigned int wakeirq;
> +
> + list_for_each(pos, &pcso->wakeirqs) {
> + struct pcs_reg *pcsoi;
> + u16 val;
> +
> + pcsoi = list_entry(pos, struct pcs_reg, node);
> + wakeirq = pcsoi->irq;
> + val = pcsoi->read(pcsoi->reg);
> + if ((val & OMAP_WAKEUP_EVENT_MASK) == OMAP_WAKEUP_EVENT_MASK)
> + generic_handle_irq(wakeirq);
> + }
> +
> + if (pcso->reconfigure_io_chain)
> + pcso->reconfigure_io_chain();
> +
> + return IRQ_HANDLED;
> +}
I fail to see why this is OMAP-specific.
I would prefer that this gets handled directly in the pinctrl core or
atleast in pinctrl-single in a generic way - latent IRQs is a generic
problem.
And I would also like it to work the other way around: when
irq_set_wake() is called from the irqchip it percolates down
to the pinctrl core and sets up a cross reference like this, for the pin,
so when an IRQ like this occurs, it will be routed up if and only
if it has been flagged as a wakeup from the irqchip layer.
The cross reference can be stored in struct pin_desc.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
