On 07/21/2013 04:42 PM, Rob Herring wrote: > Wouldn't the correct fix be to call insert_resource somehow? Yes unless there was a reason this wasn't done in the first place. > The problem > I have is that while of_platform_populate is all about parsing the DT > and creating devices, the removal side has nothing to do with DT. So > this should not be in the DT code. I think the core device code should > be able to handle removal if the device creation side is done correctly. If there is no need to use the special removal function (in case we add insert_ressource) then yes. What about a pointer in of_platform_populate()'s comment referring to the removal function? > > It looks to me like of_device_add either needs to call > platform_device_add rather than device_add. I think the device name > setting in platform_device_add should be a nop. If not, a check that the > name is already set could be added. It does actually the same thing as platform_device_add except the "dynamic device id" and the resource insert if I remember correctly. If you guys prefer the platdorm_device_add() path including insert_ressource() I can try this. > > Rob Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
