Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Mugunthan V N <mugunthanvnm@xxxxxx>
Date: Fri, 19 Jul 2013 19:37:21 +0530

> Add support to show CPSW hardware statistics to user via ethtool get_regs
> ops so user can find if there were any error reported or the system is
> over loaded duing hagh data rate transfer.
> 
> Signed-off-by: Mugunthan V N <mugunthanvnm@xxxxxx>

This is not the correct way to provide this functionality.  ->get_regs()
is for dumping the raw hardware registers to userspace for low level
debugging purposes, not for providing HW specific statistics.

The correct thing to do is provide an appropriate implementation of
the ->get_strings() and ->get_ethtool_stats() methods.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux