Hi, On Thursday 04 July 2013 05:14 PM, Tony Lindgren wrote:
* Kishon Vijay Abraham I <kishon@xxxxxx> [130619 01:58]:In order for controllers to get PHY in case of non dt boot, the phy binding information (phy label) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> Acked-by: Felipe Balbi <balbi@xxxxxx> Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> --- arch/arm/mach-omap2/usb-musb.c | 6 +++++- include/linux/usb/musb.h | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c index 3242a55..5ddbe39 100644 --- a/arch/arm/mach-omap2/usb-musb.c +++ b/arch/arm/mach-omap2/usb-musb.c @@ -85,8 +85,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) musb_plat.mode = board_data->mode; musb_plat.extvbus = board_data->extvbus; - if (cpu_is_omap44xx()) + if (cpu_is_omap44xx()) { musb_plat.has_mailbox = true; + musb_plat.phy_name = "omap-usb2"; + } else if (cpu_is_omap34xx()) { + musb_plat.phy_name = "twl4030"; + } if (soc_is_am35xx()) { oh_name = "am35x_otg_hs";Care to refresh this patch against the current mainline tree?
I'll do that on monday as I'm not in office and I dont have any boards to test at my disposal now.
Now omap4 is DT only, so this part won't apply. Mostly I'm wondering what the phy_name should be for am35xx that's not covered by this patch.
am35xx doesn't have a separate PHY driver yet (I guess the programming is done in the controller code now). So this binding is not needed for am35xx.
Also let me know if the last patch is safe to queue alone as a fix or if it depends on the driver related changes in this series.
No. The last patch is kind-of cleanup needed after applying the first 3 patches. It's better it's applied along with the other patches. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
