On 07/04/2013 12:45 PM, Mark Brown wrote: > On Thu, Jul 04, 2013 at 11:02:41AM +0200, Sebastian Andrzej Siewior > wrote: > >> The driver here does not use atomic updates but read followed by >> write so your locking here is futile. So the API/regmap alone >> does not make > > Doesn't that sound like the driver ought to be using a r/m/w > primitive though? It does this in the init phase before the child devices are created so no harm is done. I just wanted to say that regmap alone does not help as long as the use simply replaces all reads & writes with regmap reads & writes. > >> it right. And look: the MFD part uses regmap. Its children (IIO >> & input) do not use it. After I told this Samuel he said that it >> is okay. > > Again I think the point here was that they probably ought to do > so. It didn't sound that way. > But I guess if you're saying there's no problem that's fine... Thank you. Samuel, is it okay if I repost the patch? It can wait till past -rc1 if you are willing to take it. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
