> > On Tuesday 02 July 2013, Pekon Gupta wrote: > > (+ CC: devicetree-discuss@xxxxxxxxxxxxxxxx) > > > > Changes v3 -> v4 > > - [Patch 1/3] removed MTD_NAND_OMAP_BCH8 & > MTD_NAND_OMAP_BCH4 from nand/Kconfig > > ECC scheme selectable via nand DT (nand-ecc-opt). > > - [*] rebased for l2-mtd.git > > Do you also fix these build error? > > /git/arm-soc/drivers/mtd/nand/omap2.c: In function 'omap_nand_probe': > /git/arm-soc/drivers/mtd/nand/omap2.c:1964:7: error: > 'OMAP_ECC_BCH8_CODE_HW_DETECTION_SW' undeclared (first use in this > function) > case OMAP_ECC_BCH8_CODE_HW_DETECTION_SW: > ^ > /git/arm-soc/drivers/mtd/nand/omap2.c:1964:7: note: each undeclared > identifier is reported only once for each function it appears in > /git/arm-soc/drivers/mtd/nand/omap2.c:1991:7: error: > 'OMAP_ECC_BCH4_CODE_HW_DETECTION_SW' undeclared (first use in this > function) > case OMAP_ECC_BCH4_CODE_HW_DETECTION_SW: > ^ > > > Arnd [Pekon]: Yes, I'm not seeing these build issues, as I'm cleanly returning from probe with pr_err(), if the required libraries (/lib/bch.c) are not build-in the system. ------------------- [Patch v4 1/4]: mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC.. @@static int omap_nand_probe(struct platform_device *pdev) + default: + pr_err("selected ECC scheme not supported or not enabled\n"); + err = -EINVAL; + goto out_release_mem_region; + } ------------------- However, if you are still seeing this, could you please send me your config? with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html