On Tue, Jul 2, 2013 at 9:46 PM, Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> wrote: > The OMAP GPIO driver check if the chip has an associated > Device Tree node using the struct gpio_chip of_node member. > > But this is only build if CONFIG_OF_GPIO is defined which > leads to the following error when using omap1_defconfig: > > linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_chip_init': > linux/drivers/gpio/gpio-omap.c:1080:17: error: 'struct gpio_chip' has no member named 'of_node' > linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_map': > linux/drivers/gpio/gpio-omap.c:1116:16: error: 'struct gpio_chip' has no member named 'of_node' > > Reported-by: Kevin Hilman <khilman@xxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > --- > > Hi Linus, > > Sorry for not spoting this issue before. In a previous version of the patch-set: > > [PATCH v3 0/2]: auto request GPIO as input if used as IRQ via DT > > of_have_populated_dt() was used instead of struct gpio_chip of_node member to > check wether legacy or DT boot was used. I did a build test on every OMAP platform > but later I was asked to use .of_node instead of_have_populated_dt() and forget > to do a built test for OMAP1. Such things happen ... > I hope this patch can go as a fix for the v3.11-rc cycle. Yeah I queued it on top of the others. Good thing I didn't rush the other two out :-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
