> Hi Pekon,
>
> On Sun, 2013-06-23 at 23:28 +0530, Pekon Gupta wrote:
> > +---------------------------------------+---------------+---------------+
> > | ECC scheme |ECC calculation|Error
> detection|
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_HAMMING_CODE_DEFAULT |S/W |S/W
> |
> > |OMAP_ECC_HAMMING_CODE_HW |H/W (GPMC) |S/W
> |
> > |OMAP_ECC_HAMMING_CODE_HW_ROMCODE |H/W (GPMC) |S/W
> |
> > +---------------------------------------+---------------+---------------+
> > |(requires CONFIG_MTD_NAND_ECC_BCH) | |
> |
> > |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W
> |
> > +---------------------------------------+---------------+---------------+
> > |(requires CONFIG_MTD_NAND_OMAP_BCH) | |
> |
> > |OMAP_ECC_BCH8_CODE_HW |H/W (GPMC) |H/W
> (ELM) |
> > +---------------------------------------+---------------+---------------+
>
> This is a nice table, and you are doing very good job clearly
> classifying what is going on. I'd suggest to also put stuff like this to
> comments in the code.
>
[Pekon]: Thanks for encouragement, would include more inline comments in future.
> > This patch
> > - separates the configurations for various ECC schemes.
> > - fixes dependency issues based on Kconfig options.
> > - cleans up redundant code
> >
> > Signed-off-by: Pekon Gupta <pekon@xxxxxx>
>
> This does not apply to l2-mtd.git, could you please re-base?
>
[Pekon]: rebased to l2-mtd.git
- updated [Patch 3/4] which conflicted with commit '26331c04' which touched omap2.c.
- Please ignore [Patch 4/4] as it’s a DT update, which adds on top of Benoit's tree (which has NAND node commits too).
Thanks for accepting..
with regards, pekon
> --
> Best Regards,
> Artem Bityutskiy
��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
