On 6/17/2013 9:10 PM, Fernandes, Joel A wrote: > Hi Arnd, > >> -----Original Message----- >> From: Arnd Bergmann [mailto:arnd@xxxxxxxx] >> Sent: Monday, June 17, 2013 6:13 AM >> To: Fernandes, Joel A >> Cc: Tony Lindgren; Nori, Sekhar; Matt Porter; Grant Likely; Rob Herring; Vinod >> Koul; Mark Brown; Cousson, Benoit; Russell King; Rob Landley; Andrew >> Morton; Jason Kridner; Koen Kooi; Devicetree Discuss; Linux OMAP List; Linux >> ARM Kernel List; Linux DaVinci Kernel List; Linux Kernel Mailing List; Linux >> Documentation List; Linux MMC List; Linux SPI Devel List >> Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree >> binding >> >> On Friday 14 June 2013 21:32:47 Joel A Fernandes wrote: >>> >>> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt >>> b/Documentation/devicetree/bindings/dma/ti-edma.txt >>> new file mode 100644 >>> index 0000000..ada0018 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt >>> @@ -0,0 +1,26 @@ >>> +TI EDMA >>> + >>> +Required properties: >>> +- compatible : "ti,edma3" >>> +- ti,hwmods: Name of the hwmods associated to the EDMA >>> +- ti,edma-regions: Number of regions >>> +- ti,edma-slots: Number of slots >>> + >>> +Optional properties: >>> +- ti,edma-xbar-event-map: Crossbar event to channel map >> >> You need to list #dma-cells as required here, and which values are accepted >> by the driver (I suppose only <1>). You should also explain the format of the >> dma-specifier for a slave here for each possible value of #dma-cells. >> >> For each of the standard properties (reg, interrupts, dma-channels), list >> whether they are optional or required. Since the example has three >> interrupts, you should probably list how many interrupts need to be specified >> (minimum and maximum if the number is variable) and in what order to >> expect them. > > [Joel] Thanks for the suggestion, I updated it and it looks like this now: > > Required properties: > - compatible : "ti,edma3" > - ti,hwmods: Name of the hwmods associated to the EDMA I have already asked for ti,hwmods to be made optional. Please see my comment from yesterday. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
