2013/5/17 Gupta, Pekon <pekon@xxxxxx>: > From: "Gupta, Pekon" <pekon@xxxxxx> > > [Change v1 -> v2] > added [PATCH 3/4] and [PATCH 4/4] > > [PATCH 1/4]: clean-up and optimization for supported ECC schemes. > [PATCH 2/4]: add separate DT options each supported ECC scheme. > [PATCH 3/4]: update BCH4 ECC implementation (using ELM or using lib/bch.h) > [PATCH 4/4]: update DT attribute for ti,nand-ecc-opt > > After this patch series, omap2-nand driver will supports following ECC schemes: > +---------------------------------------+---------------+---------------+ > | ECC scheme |ECC calculation|Error detection| > +---------------------------------------+---------------+---------------+ > |OMAP_ECC_HAMMING_CODE_DEFAULT |S/W |S/W | > |OMAP_ECC_HAMMING_CODE_HW |H/W (GPMC) |S/W | > |OMAP_ECC_HAMMING_CODE_HW_ROMCODE |H/W (GPMC) |S/W | > +---------------------------------------+---------------+---------------+ > |OMAP_ECC_BCH4_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W (lib/bch.h)| > |OMAP_ECC_BCH4_CODE_HW |H/W (GPMC) |H/W (ELM) | > +---------------------------------------+---------------+---------------+ > |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W (lib/bch.h)| > |OMAP_ECC_BCH8_CODE_HW |H/W (GPMC) |H/W (ELM) | > +---------------------------------------+---------------+---------------+ > - Selection of OMAP_ECC_BCHx_CODE_HW_DETECTION_SW requires, > Kconfig: CONFIG_MTD_NAND_ECC_BCH: enables S/W based BCH ECC algorithm. > > - Selection of OMAP_ECC_BCHx_CODE_HW requires, > Kconfig: CONFIG_MTD_NAND_OMAP_BCH: enables ELM H/W module. > > Hi, Thank you for not dropping BCH4 with software detection. BCH4_CODE_HW_DETECTION_SW tested sucessfully on an existing nand with BCH4 ECC. - Linux flashed kernel was read by u-boot sucessfully. - existing ubifs sucessfully mounted. Regards, Jean-Philippe François > Gupta, Pekon (4): > mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in > device_probe > ARM: OMAP2+: cleaned-up DT support of various ECC schemes > mtd:nand:omap2: updated support for BCH4 ECC scheme > ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT > > .../devicetree/bindings/mtd/gpmc-nand.txt | 52 ++- > arch/arm/boot/dts/am335x-evm.dts | 2 +- > arch/arm/mach-omap2/gpmc.c | 17 +- > drivers/mtd/nand/Kconfig | 1 - > drivers/mtd/nand/omap2.c | 413 +++++++++------------ > include/linux/platform_data/elm.h | 4 + > include/linux/platform_data/mtd-nand-omap2.h | 22 +- > 7 files changed, 253 insertions(+), 258 deletions(-) > > -- > 1.8.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html