[PATCH] rtc: rtc-twl: Fix missing device_init_wakeup() when booted with device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When booted in legacy mode device_init_wakeup() gets called
by drivers/mfd/twl-core.c when the children are initialized.
However, when booted using device tree, the children are
created with of_platform_populate() instead add_children().

This means that the RTC driver will not have device_init_wakeup()
set, and we need to call it from the driver probe like RTC drivers
typically do.

Without this we cannot test PM wake-up events on omaps for
cases where there may not be any physical wake-up event.

Reported-by: Kevin Hilman <khilman@xxxxxxxxxx>
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

---

This fix is for the -rc cycle please.

--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -524,6 +524,7 @@ static int twl_rtc_probe(struct platform_device *pdev)
 	}
 
 	platform_set_drvdata(pdev, rtc);
+	device_init_wakeup(&pdev->dev, 1);
 	return 0;
 
 out2:
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux