RE: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Tony Lindgren [mailto:tony@xxxxxxxxxxx]
> Sent: Friday, May 17, 2013 10:55 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> Paul Walmsley
> Subject: Re: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info
> to GFX hwmod
> 
> * Hiremath, Vaibhav <hvaibhav@xxxxxx> [130517 04:13]:
> >
> > > -----Original Message-----
> > > From: Hiremath, Vaibhav
> > > Sent: Sunday, May 05, 2013 12:18 AM
> > > To: linux-omap@xxxxxxxxxxxxxxx
> > > Cc: tony@xxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> Hiremath,
> > > Vaibhav; Paul Walmsley
> > > Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info
> to
> > > GFX hwmod
> > >
> > > GFX has a reset status register (PRM_GFX.RM_GFX_RSTST),
> > > so update the GFX hwmod data with .rstst_off and .st_shift
> > > information.
> > >
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> > > Cc: Paul Walmsley <paul@xxxxxxxxx>
> > > ---
> > >  arch/arm/mach-omap2/omap_hwmod_33xx_data.c |    3 ++-
> > >  1 files changed, 2 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > index d1cf3ab..38c7b04 100644
> > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > > @@ -329,7 +329,7 @@ static struct omap_hwmod_class
> > > am33xx_gfx_hwmod_class = {
> > >  };
> > >
> > >  static struct omap_hwmod_rst_info am33xx_gfx_resets[] = {
> > > -	{ .name = "gfx", .rst_shift = 0 },
> > > +	{ .name = "gfx", .rst_shift = 0, .st_shift = 0},
> > >  };
> > >
> > >  static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
> > > @@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = {
> > >  		.omap4	= {
> > >  			.clkctrl_offs	= AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET,
> > >  			.rstctrl_offs	= AM33XX_RM_GFX_RSTCTRL_OFFSET,
> > > +			.rstst_offs	= AM33XX_RM_GFX_RSTST_OFFSET,
> > >  			.modulemode	= MODULEMODE_SWCTRL,
> > >  		},
> > >  	},
> > > --
> >
> > Tony and Paul,
> >
> > Any Update on this one as well?
> 
> Is this needed for v3.10 as a fix? If so, it should describe the
> regression or error.
> 

Certainly this is fix, but no impact on kernel boot.
I will describe it more in the description and send next version shortly.

Thanks,
Vaibhav

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux