On Friday 17 May 2013, Gupta, Pekon wrote: > From: "Gupta, Pekon" <pekon@xxxxxx> > > Updates ECC scheme selection string same to same as used in omap2-driver code. > This makes the DT configurations easy to understand and map to actual code. > > Signed-off-by: Gupta, Pekon <pekon@xxxxxx> This moves the binding in the wrong direction. First of all, you should never make incompatible changes to a specification document. > - "bch8_hw_detection_sw" 8-bit BCH with ECC calculation in hardware > - and error detection in software > - - requires Kconfig CONFIG_MTD_NAND_ECC_BCH The binding before your change is already broken since it refers to Linux-specific Kconfig symbols, and you fail to fix that. > + "OMAP_ECC_BCH4_CODE_HW_DETECTION_SW" > + 4-bit BCH with ECC calculation in > + hardware & error detection in software. > + - requires CONFIG_MTD_NAND_ECC_BCH Instead you make it worse by using /more/ Linux-isms in the binding. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
