> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Wednesday, March 27, 2013 11:15 PM > To: Tony Lindgren; Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > Nayak, Rajendra > Subject: Re: [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to > clkdiv32k_ick clock > > On Wed, 27 Mar 2013, Vaibhav Hiremath wrote: > > > It is required to enable respective clock-domain before > > enabling any clock/module inside that clock-domain. > > > > During common-clock migration, .clkdm_name field got missed > > for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm" > > unused; so it will be disabled even if childs of this clock-domain > > is enabled, which keeps child modules in idle mode. > > > > This fixes the kernel crash observed on AM335xEVM-SK platform, > > where clkdiv32_ick clock is being used as a gpio debounce clock > > and since clkdiv32k_ick is in idle mode it leads to below crash - > > > > Crash Log: > > ========== > > [ 2.598347] Unhandled fault: external abort on non-linefetch > (0x1028) at > > 0xfa1ac150 > > [ 2.606434] Internal error: : 1028 [#1] SMP ARM > > [ 2.611207] Modules linked in: > > [ 2.614449] CPU: 0 Not tainted (3.8.4-01382-g1f449cd-dirty #4) > > [ 2.620973] PC is at _set_gpio_debounce+0x60/0x104 > > [ 2.626025] LR is at clk_enable+0x30/0x3c > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > Cc: Paul Walmsley <paul@xxxxxxxxx> > > Cc: Rajendra Nayak <rnayak@xxxxxx> > > Acked-by: Paul Walmsley <paul@xxxxxxxxx> > > Tony, if it isn't too late, could this one be added to your 3.9-rc > fixes > series? > > Looks like we missed this so far. Tony, can you merge this patch for v3.10-rc ? Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html