On Thu, May 16, 2013 at 3:22 PM, Dan Murphy <dmurphy@xxxxxx> wrote: > On 05/16/2013 01:18 PM, Nishanth Menon wrote: >> On Thu, May 16, 2013 at 10:35 AM, Dan Murphy <dmurphy@xxxxxx> wrote: >>> I am not sure you really want to do this. >>> If I make the pinctrl part of the led structure then the only way the gpio_wk7 on a1-a3 to be configured is when >>> the CONFIG_LEDS_GPIO flag is set. >>> >>> Do you really want that dependency? You did say it was a key fix >>> At least this way the pins are configured regardless of that flag. >> That is better as the system will be left in the pinmux configuration >> handed over from bootloader. > So you want to depend on a boot loader to configure pins correctly for the kernel? > Hmmm seems risky to me. Not really! if it is a critical pinmux, pinmux defaults are great, else belongs definitely to device->pinctrl :) depending on bootloader pinmux implies NOT having pinmux even for device - NO. that is definitely not what I stated. Regards, NM -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html