On Tue, May 07, 2013 at 01:06:38, Mark Brown wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device > core) we can rely on device core for handling pinctrl so remove > devm_pinctrl_get_select_default() from the driver. NACK. There are cases where driver('s) needs to place pin-mux's to sleep on suspend & default/idle on resume. For such cases Pinctrl needs to be handled inside the driver. Example [1]. I will be submitting a patch to enhance the existing pinctrl support for spi omap2 shortly which does above work. Regards Gururaja [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-pl022.c pl022_suspend_resources() & pl022_resume_resources() > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/spi/spi-omap2-mcspi.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > index 893c3d7..3777bd5 100644 > --- a/drivers/spi/spi-omap2-mcspi.c > +++ b/drivers/spi/spi-omap2-mcspi.c > @@ -38,7 +38,6 @@ > #include <linux/pm_runtime.h> > #include <linux/of.h> > #include <linux/of_device.h> > -#include <linux/pinctrl/consumer.h> > > #include <linux/spi/spi.h> > > @@ -1170,7 +1169,6 @@ static int omap2_mcspi_probe(struct platform_device *pdev) > static int bus_num = 1; > struct device_node *node = pdev->dev.of_node; > const struct of_device_id *match; > - struct pinctrl *pinctrl; > > master = spi_alloc_master(&pdev->dev, sizeof *mcspi); > if (master == NULL) { > @@ -1268,11 +1266,6 @@ static int omap2_mcspi_probe(struct platform_device *pdev) > if (status < 0) > goto dma_chnl_free; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, > - "pins are not configured from the driver\n"); > - > pm_runtime_use_autosuspend(&pdev->dev); > pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT); > pm_runtime_enable(&pdev->dev); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html