On Thu, 2013-04-25 at 03:56 -0400, David Miller wrote: > From: Mugunthan V N <mugunthanvnm@xxxxxx> > Date: Mon, 22 Apr 2013 23:50:36 +0530 > > > In earlier case phy fixup are added in board file as this is no more the case > > so adding support for phy register fixup in Device Tree > > > > Signed-off-by: Mugunthan V N <mugunthanvnm@xxxxxx> > > When people put a series of undocumented PHY register writes using > constants, we tell them it's firmware. > > If these PHY registers are actually documented in the driver, write a > function in that driver which does the programming sequence, then add > a property that the driver looks for in order to determine whether to > call that sequence or not. > > I don't want people putting random PHY raw programming sequences and > other crap like that into the OF device nodes. It's extremely > inelegant and inviting abuse. I don't think booleans will be enough in general; a PHY may well require link tuning for a specific board. But the set of register addresses to program is likely to be known in advance and then only the values would belong in DT. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
