Hi, On 2013-04-16 10:44, Peter Ujfalusi wrote: > Convert the driver to use module_platform_driver() to register the platform > driver and relocate the rtc_reg_map initialization to platform driver's > probe function. > In this way we can make sure that the twl-core has been already probed since > the core driver will create the device at the end of it's probe function. > > Reported-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> I think there are two distinct things here. The actual fix for the regmap, and a module_platform_driver cleanup. I would suggest having them in separate patches. And even if these are combined, I think the patch subject and description should talk about fixing the regmap bug. Now it's rather unclear that an actual bug is being fixed. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html