On Monday 15 April 2013 10:36 AM, Hiremath, Vaibhav wrote: > >> -----Original Message----- >> From: Shilimkar, Santosh >> Sent: Wednesday, April 10, 2013 5:02 PM [..] >>>> From b95dd33fe59b8e77727eb3b1717d763bbf9a2893 Mon Sep 17 00:00:00 >> 2001 >>>> From: Sricharan R <r.sricharan@xxxxxx> >>>> Date: Fri, 5 Apr 2013 20:39:12 +0530 >>>> Subject: [PATCH] ARM: AM33XX: hwmod data: Clean up the data file >>>> >>>> - The IO resource information like dma request lines, irq number and >>>> ocp address space can be populated via dt blob. So such data can be >>>> stripped >>>> from SOC hwmod data file. >>>> >>>> - The devices like adc, mailbox, gpmc which are missing the device >>>> tree bindings, hwmod data is not added since AM33XX is DT only >> build. >>>> When such devices add the dt bindings, respective hwmod data can be >>>> added along with it. >>>> >>> This seems unnecessary churn to me. DT bindings for most of the >> devices >>> which you mentioned above are submitted and are at various stages of >> review >>> process. >>> >>> ADC: >>> >>> GPMC: >>> >>> PWM: >>> >> The modules are dropped as per what is going for 3.10 merge window. >> Above 3 modules can be retained if the DT conversion patches are >> under review and can go along with this patch most likely for 3.11. >> >>> >>>> - The hwmod like firewall etc which are not useful are also dropped. >>>> >>>> This gets us around ~2000 loc of negative diff. Patch is boot tested >> on >>>> AM335X EVM. >>>> >>> I would not recommend to get into unnecessary code churn in the >> future just >>> to reduce temp Number of Lines of code. This will also kill our >> autogeneration >>> concept as well. >>> >> It doesn't break any concept. We just autogenrate what is *useful* >> rather. >> BTW, I didn't find any srcipt to auto-generate the AM33XX data so we >> have >> to manually do the updates. Can you send me a pointer if you have a >> sript >> for this. With script it is much simpler to clean-up the data. >> >> >>> I would suggest you to just alone drop base-addr, irq and dma >> references >>> from hwmod entries. >>> >> That we are doing anyways. Apart from that we should also clean-up data >> which is not used and useful. Why do you need unused data like firewall >> and >> friends ? >> >> So as I understood, you would like to keep the data for ADC, PWM and >> GPMC >> which is fine by me. We just need those DT bindings in place so that >> they >> go together. Who is following the DT patches for these ? >> >> Thanks for looking into it Vaibhav. >> > Are you planning to send updated version of this? > I would rather prefer to review next version. > > Please let me know if you need any help here. > Yes :-) It will be great if you take the patch forward and update it based on the discussion. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
