On Sat, Apr 13, 2013 at 8:59 PM, Christoph Fritz
<chf.fritz@xxxxxxxxxxxxxx> wrote:
> On Sat, 2013-04-13 at 20:30 +0200, Javier Martinez Canillas wrote:
>> On Sat, Apr 13, 2013 at 7:42 PM, Christoph Fritz
>> <chf.fritz@xxxxxxxxxxxxxx> wrote:
>
>> Yes, my last approach to solve the IRQ flags not saved on the
>> IORESOURCE_IRQ struct resource issue is to add a new
>> irq_get_trigger_type() function to get the edge/level flags from an
>> IRQ number and use that function on the smsc911x driver probe function
>> to get the IRQ flags.
>>
>> The patch-set is composed of these patches:
>>
>> [PATCH v2 1/2] genirq: add function to get IRQ edge/level flags [1]
>> [PATCH 2/2] net: smsc911x: get IRQ flags from chip if not present in
>> IORESOURCE_IRQ [2]
>>
>> and the cover letter is this [3]
>>
>> It would be great if you can test these patches and give some feedback.
>>
>> > For me it works when doing this in the device tree:
>> >
>> > +&omap3_pmx_wkup {
>> > + pinctrl-names = "default";
>> > +
>> > + lan9221_pins: pinmux_lan9221_pins {
>> > + pinctrl-single,pins = <
>> > + 0x5A 0x104 /* gpio_129, INPUT | MODE4 */
>> > + >;
>> > + };
>> > +};
>> > +
>> > <SNIP>
>> > + lan9221@15000000 {
>> > + compatible = "smsc,lan9221", "smsc,lan9115";
>> > + reg = <0x15000000 0x400>;
>>
>> If I understood correctly your smsc ethernet chip is connected to the
>> OMAP through the GPMC, then you should use a chip-select, base address
>> and size instead of the physical address and size.
>
> Yes, it's connected with GPMC.
>
>> Do you have commit 5330dc161 ("ARM: OMAP2+: Add GPMC DT support for
>> Ethernet child nodes") already on your tree? [4]
>
> No I haven't.
>
In that case you should have that commit on your tree. But the GPMC
driver has changed a lot for 3.9 and 3.10, so I recommend you to base
your work on linux-next that has the latest changes.
And then you will need something like this on your DT (in this example
is using the chip-select 5 but adjust according to your board):
gpmc: gpmc@6e000000 {
compatible = "ti,omap3430-gpmc";
ti,hwmods = "gpmc";
reg = <0x6e000000 0x1000>;
interrupts = <20>;
gpmc,num-cs = <8>;
gpmc,num-waitpins = <4>;
#address-cells = <2>;
#size-cells = <1>;
ranges = <5 0 0x2c000000 0x1000000>;
ethernet@5,0 {
pinctrl-names = "default";
pinctrl-0 = <&lan9221_pins>;
compatible = "smsc,lan9221", "smsc,lan9115";
reg = <5 0 0xff>;
bank-width = <2>;
gpmc,mux-add-data;
gpmc,cs-on-ns = <0>;
gpmc,cs-rd-off-ns = <186>;
gpmc,cs-wr-off-ns = <186>;
gpmc,adv-on-ns = <12>;
gpmc,adv-rd-off-ns = <48>;
gpmc,adv-wr-off-ns = <48>;
gpmc,oe-on-ns = <54>;
gpmc,oe-off-ns = <168>;
gpmc,we-on-ns = <54>;
gpmc,we-off-ns = <168>;
gpmc,rd-cycle-ns = <186>;
gpmc,wr-cycle-ns = <186>;
gpmc,access-ns = <114>;
gpmc,page-burst-access-ns = <6>;
gpmc,bus-turnaround-ns = <12>;
gpmc,cycle2cycle-delay-ns = <18>;
gpmc,wr-data-mux-bus-ns = <90>;
gpmc,wr-access-ns = <186>;
gpmc,cycle2cycle-samecsen;
gpmc,cycle2cycle-diffcsen;
interrupt-parent = <&gpio5>;
interrupts = <1 0x2>;
reg-io-width = <4>;
vdd33a-supply = <®_vcc3>;
vmmc_aux-supply = <&vdd33a>;
vddvario-supply = <®_vcc3>;
};
};
>>
>> > + phy-mode = "mii";
>> > + interrupt-parent = <&gpio5>;
>> > + interrupts = <1 0x2>; /* gpio_129, trigger: falling-edge */
>>
>> I'm confused here, do you get the IRQ_TYPE_EDGE_FALLING (0x2) trigger
>> type flag on the smsc911x driver probe function?
>
> I added printks for irq_res->flags and irq_flags:
> [ 1.259857] smsc911x_drv_probe, 2396, irq_res->flags 0x00000400
> [ 1.266113] smsc911x_drv_probe, 2397, irq_flags 0x00000000
>
> So the answer is no. But weird that the smsc911x works nevertheless.
>
Yes, that's what I thought. You will need patch [1] and [2] to allow
smsc911x driver to get the GPIO-IRQ trigger type flags.
With those patches + linux-next + the device node I posted above +
your gpio_request_one() hack on gpmc_probe_dt() should be enough to
have your smsc ethernet chip working on your board.
>>
>> > + reg-io-width = <4>;
>> > + vdd33a-supply = <®_vcc3>;
>> > + vddvario-supply = <®_vcc3>;
>> > + pinctrl-names = "default";
>> > + pinctrl-0 = <&lan9221_pins>;
>> > + };
>> >
>> > but in arch/arm/mach-omap2/gpmc.c gpmc_probe_dt() I still need this
>> > hack:
>> >
>> > + ret = gpio_request_one(129, GPIOF_IN, "lan9221 irq");
>> > + if (ret) {
>> > + pr_err("Failed to request IRQ GPIO%d\n", 129);
>> > + return ret;
>> > + }
>> >
>>
>> Yes, this hack is still needed until we figure out how to enable the
>> GPIO bank before a call to request_irq() is made.
>>
>> > The following patches (already sent mainline) are also applied:
>> > "arm/dts: OMAP3: fix pinctrl-single configuration"
>> > "net: smsc911x: adopt pinctrl support"
>> >
>>
>> Yes, but that patch is not needed anymore from 3.9, look at this [5]
>>
>> [1]: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg88241.html
>> [2]: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg88225.html
>> [3]: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg88224.html
>> [4]: https://patchwork.kernel.org/patch/2273851/
>> [5]: http://marc.info/?l=linux-kernel&m=135887740715083&w=2
>
> Thanks
> -- Christoph
>
>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
