On 04/12/2013 12:05 PM, Javier Martinez Canillas wrote: ... > So, is better to add an irq_get_trigger_type() function to obtain > the edge/level flags for an IRQ. > diff --git a/include/linux/irq.h b/include/linux/irq.h > +static inline u32 irq_get_trigger_type(unsigned int irq) > +{ > + struct irq_data *d = irq_get_irq_data(irq); > + return d ? d->state_use_accessors & IRQD_TRIGGER_MASK : 0; Should the direct access to d->state_use_accessors be replaced with a call to irqd_get_trigger_type()? Perhaps since this is inside the IRQ code header, there's no need to use the accessor function? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html