Felipe, On 04/11/2013 04:02 PM, Alexander Holler wrote: > Am 11.04.2013 14:42, schrieb Roger Quadros: >> On 04/11/2013 01:55 PM, Felipe Balbi wrote: > >>> I would avoid 'select' completely and just update omap2plus_defconfig >>> adding those two as modules. Setting USB_PHY as a module gives rise to these problems arch/arm/mach-omap2/built-in.o: In function `usbhs_init_phys': /work/linux-2.6/arch/arm/mach-omap2/usb-host.c:652: undefined reference to `usb_bind_phy' arch/arm/mach-omap2/built-in.o: In function `omap_2430sdp_init': /work/linux-2.6/arch/arm/mach-omap2/board-2430sdp.c:236: undefined reference to `usb_bind_phy' arch/arm/mach-omap2/built-in.o: In function `omap3_beagle_init': /work/linux-2.6/arch/arm/mach-omap2/board-omap3beagle.c:554: undefined reference to `usb_bind_phy' arch/arm/mach-omap2/built-in.o: In function `devkit8000_init': /work/linux-2.6/arch/arm/mach-omap2/board-devkit8000.c:596: undefined reference to `usb_bind_phy' arch/arm/mach-omap2/built-in.o: In function `omap_ldp_init': /work/linux-2.6/arch/arm/mach-omap2/board-ldp.c:379: undefined reference to `usb_bind_phy' So USB_PHY shouldn't be tristate IMO or at least the platform registration stuff as the usb_bind_phy() part is used by platform code. >>> >> >> OK, makes sense. I will update the patch to remove "select NOP_USB_XCEIV". > > Sorry, but this just will end up with many users having broken configs > because of disabled stuff they don't know why they have to enable them. > And thus with a never ending stream of questions and thus with a needed > FAQ entry. > Alexander, I agree with you that it can get difficult with users. But it is best for users do not disable anything they are not familiar with. As the USB_PHY option doesn't depend on anything, it is safe to select it from USB_EHCI_HCD_OMAP. However, the PHY drivers themselves must be selected from the board configs. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
