* Jon Hunter <jon-hunter@xxxxxx> [130410 10:35]: > Hi Tony, > > On 04/09/2013 04:23 PM, Tony Lindgren wrote: > > Hi Jon, > > > > Looks like at least 4430sdp nfsroot got broken with commit > > ff5c9059 (ARM: dts: OMAP3+: Correct gpio #interrupts-cells > > property). > > Thanks for reporting. I am actually amazed that ethernet is > working on any OMAP board (with device-tree) that requires a > gpio as an interrupt because we have still not come to an > agreement on [1]. Looking at the OMAP4 SDP I believe this is > working by luck because there are other gpios in the same > bank that are active and so the bank is enabled. If that were > not the case then this would not work. > > Hence, I have not been testing ethernet when booting with > device-tree because we need to fix [1] which has been really > crippling my testing. So this needs to be resolved so ethernet > can work consistently on all omap boards. Cool. > > Do we need to pass the GPIO edge/level info now? > > Yes and here is a patch. I have tested on my OMAP4 SDP this > morning. Reviewing all the OMAP/AM dts(i) files I believe > that only the SDP and OMAP4-VAR-SOM are impacted by this. I > don't see any other boards currently using the gpio as an > interrupt-controller. Great. Just one comment: You might be able to already use the DT preprocessor now easily with linux next for the edge info. Regards, Tony > [1] comments.gmane.org/gmane.linux.ports.arm.omap/92192 > > From ed3e66bcd4c0cb3df4cb70e75c45fa4462f70565 Mon Sep 17 00:00:00 2001 > From: Jon Hunter <jon-hunter@xxxxxx> > Date: Wed, 10 Apr 2013 11:44:44 -0500 > Subject: [PATCH] ARM: dts: OMAP4: Fix ethernet IRQ for OMAP4 boards > > Commit ff5c9059 (ARM: dts: OMAP3+: Correct gpio #interrupts-cells > property) updated the number of interrupt cells required for configuring > gpios as interrupts for other devices (such as ethernet controllers). > This update allowed the interrupt type (edge, level, etc) to be > configured via device-tree (as described in the > Documentation/devicetree/bindings/gpio/gpio-omap.txt). > > This broke ethernet support on the OMAP4 SDP board that defines a gpio > as the ethernet IRQ because the interrupt type (level, edge, etc) was > not getting configured correctly. This board use the ks8851 ethernet > chip which has an active low interrupt. Fix this by defining the gpio > interrupt as active-low in the device-tree binding. > > Please note that the OMAP4-VAR-SOM also uses the same ethernet > controller and it is expected it will have the same problem. So the > same fix is also applied to this board. > > Signed-off-by: Jon Hunter <jon-hunter@xxxxxx> > --- > arch/arm/boot/dts/omap4-sdp.dts | 2 +- > arch/arm/boot/dts/omap4-var-som.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts > index c387bdc..25cbe43 100644 > --- a/arch/arm/boot/dts/omap4-sdp.dts > +++ b/arch/arm/boot/dts/omap4-sdp.dts > @@ -363,7 +363,7 @@ > spi-max-frequency = <24000000>; > reg = <0>; > interrupt-parent = <&gpio2>; > - interrupts = <2>; /* gpio line 34 */ > + interrupts = <2 8>; /* gpio line 34, low triggered */ > vdd-supply = <&vdd_eth>; > }; > }; > diff --git a/arch/arm/boot/dts/omap4-var-som.dts b/arch/arm/boot/dts/omap4-var-som.dts > index 222a413..7e04103 100644 > --- a/arch/arm/boot/dts/omap4-var-som.dts > +++ b/arch/arm/boot/dts/omap4-var-som.dts > @@ -68,7 +68,7 @@ > spi-max-frequency = <24000000>; > reg = <0>; > interrupt-parent = <&gpio6>; > - interrupts = <11>; /* gpio line 171 */ > + interrupts = <11 8>; /* gpio line 171, low triggered */ > vdd-supply = <&vdd_eth>; > }; > }; > -- > 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
