On Tuesday 09 April 2013 10:25 PM, Tony Lindgren wrote: > * Santosh Shilimkar <santosh.shilimkar@xxxxxx> [130408 23:16]: >>> >> As I said, the IP has been there from OMAP2XX days. Here the case that >> IP version is very similar between OMAP4, OMAP5. DRA(next SOC) and its >> derivatives. Hence can share most of the code. I thought this was good >> enough reason considering at least 4 family of SOC's can make use >> of the code. > > Well at least that might be enough of a reasoning to rename it as > it is somewhat futureproof. > Yep. I can't see to much further in future but there is a *strong* mandate to not break compatibility so hopefully we won't see too much churn for similar IP blocks in future. >> It has nothing to do with SMP etc specifically and rather the similarity >> between the PM infrastructure on the mentioned SOCs. >> >> Let me know if you can suggested better name than what I chose ? > > Not really except something like pm-iprevXXX.[chS] where the rev is > the first revision that it works with? > > But then again if it's touching registers all over the place directly, > that naming does not make much sense either :) > Exactly. Thanks for the discussion. I will go ahead with rename when we add OMAP5 stuff like I did in earlier patch. i.e pm44xx.c --> pm_omap4plus.c sleep44xx.S --> sleep_omap4plus.S Regrads, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html