On 12:28-20130405, Tony Lindgren wrote:
> * Nishanth Menon <nm@xxxxxx> [130405 10:22]:
> > On 10:05-20130405, Tony Lindgren wrote:
> > >
> > > > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> > > > index afa509a..5b147ef 100644
> > > > --- a/arch/arm/mach-omap2/board-generic.c
> > > > +++ b/arch/arm/mach-omap2/board-generic.c
> > > > @@ -49,6 +49,11 @@ static void __init omap_generic_init(void)
> > > > omap4_panda_display_init_of();
> > > > else if (of_machine_is_compatible("ti,omap4-sdp"))
> > > > omap_4430sdp_display_init_of();
> > > > +
> > > > + if (IS_ENABLED(CONFIG_GENERIC_CPUFREQ_CPU0)) {
> > > > + struct platform_device_info devinfo = { .name = "cpufreq-cpu0", };
> > > > + platform_device_register_full(&devinfo);
> > > > + }
> > > > }
> > >
> > > Hmm why would the driver need this? Sounds like the driver is
> > > missing support for DT?
> > Nope, this was a long chain of discussion in previous iterations of this
> > patch.. more or less started here:
> > https://patchwork.kernel.org/patch/2251821/
> > Suggested as the generic approach for cpufreq drivers.
> > Paul questioned this approach in:
> > http://marc.info/?l=linux-pm&m=136485349218809&w=2
>
> How about just set it up in omap2_common_pm_init instead
> of the board-generic?
umm.. We want to eventually want to get rid of mach-omap2/pm.c (all
those create processor devices etc should go away with proper
representation of devices as nodes in DT if possible.
But, I think you mean something like in the "else" condition of
https://patchwork.kernel.org/patch/2359711/ ? - I'd again have the same
request of not having anything to do with pm.c and keeping as little as
possible for all TI processors in mach-omap2.
Could you enlighten me about why you'd not like it in board-generic.c?
will creating an function ti_generic_cpufreq_init() in board-generic.c
and calling it from omap_generic_init help?
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
