Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes:
> On Thursday 04 April 2013 02:19 AM, Kevin Hilman wrote:
>> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes:
>>
>>> Add power management code to handle the CPU off mode to enable CPUP hotplug
>>> mode for OMAP5 devices. Separate suspend finisher is used for OMAP5(Cortex-A15)
>>> because it doesn't use SCU power status register and external PL310 L2 cache
>>> which makes code flow bit different.
>>>
>>> Acked-by: Nishanth Menon <nm@xxxxxx>
>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>>
>> [...]
>>
>>> @@ -436,14 +445,21 @@ int __init omap4_mpuss_init(void)
>>>
>>> if (cpu_is_omap44xx()) {
>>> omap_pm_ops.finish_suspend = omap4_finish_suspend;
>>> + omap_pm_ops.hotplug_restart = omap_secondary_startup;
>>> omap_pm_ops.resume = omap4_cpu_resume;
>>> omap_pm_ops.scu_prepare = scu_pwrst_prepare;
>>> cpu_context_offset = OMAP4_RM_CPU0_CPU0_CONTEXT_OFFSET;
>>> } else if (soc_is_omap54xx()) {
>>> + omap_pm_ops.finish_suspend = omap5_finish_suspend;
>>> + omap_pm_ops.hotplug_restart = omap5_secondary_startup;
>>> cpu_context_offset = OMAP54XX_RM_CPU0_CPU0_CONTEXT_OFFSET;
>>> enable_mercury_retention_mode();
>>> }
>>>
>>> + /* Over-write the OMAP4 hook to take care of ROM BUG */
>>> + if (cpu_is_omap446x())
>>> + omap_pm_ops.hotplug_restart = omap_secondary_startup_4460;
>>
>> A couple nits...
>>
>> I think this would go better at the end of the 'if omap44xx' block
>> above.
>>
> Nishant commented on this as well. The indentation was looking ugly
> and I thought its better to have this BUG hunk separate. I prefer
> it this way though if you really insist, i have to change it.
I insist.
>> Also, while you're hear, maybe it's time to rename the current secondary
>> startup functions to match the new one. IOW omap4_..., omap4460_... and omap5_...
>>
> Good idea. Will do it in a separate patch since these have been there in few
> files.
OK.
Thanks,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
